Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Improve Python API for Keychain #315

Merged
merged 4 commits into from
Mar 24, 2023
Merged

Feature: Improve Python API for Keychain #315

merged 4 commits into from
Mar 24, 2023

Conversation

priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Mar 13, 2023 •
edited
Loading

As Keychain methods except password argument to be passed as Password instance, it makes the Python API of Keychain really cumbersome to use. To make it more user friendly, also accept plain str values wherever Password is currently used.

@priitlatt priitlatt marked this pull request as ready for review March 13, 2023 10:45
@priitlatt priitlatt merged commit f297e9c into master Mar 24, 2023
@priitlatt priitlatt deleted the feature/keychain-python-api branch March 24, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemii-yanushevskyi artemii-yanushevskyi artemii-yanushevskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@priitlatt @artemii-yanushevskyi