Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Support Apple Vision Pro device type #357

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Bugfix: Support Apple Vision Pro device type #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c3fa42
Support Apple Vision Pro device type
priitlatt Oct 2, 2023
72a64c9
Merge branch 'master' of github.com:codemagic-ci-cd/cli-tools into bu…
priitlatt Oct 2, 2023
983c193
Bump version and update changelog
priitlatt Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
Version 0.45.3
-------------

**Bugfixes**
- Support Apple Vision Pro devices in App Store Connect API read device information and list devices endpoints. This is done by declaring `APPLE_VISION_PRO` definition in enumeration `codemagic.apple.resources.enums.DeviceClass`. [PR #357](https://github.com/codemagic-ci-cd/cli-tools/pull/357)

Version 0.45.2
-------------

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "codemagic-cli-tools"
version = "0.45.2"
version = "0.45.3"
description = "CLI tools used in Codemagic builds"
readme = "README.md"
authors = [
Expand Down
2 changes: 1 addition & 1 deletion src/codemagic/__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
__title__ = "codemagic-cli-tools"
__description__ = "CLI tools used in Codemagic builds"
__version__ = "0.45.2.dev"
__version__ = "0.45.3.dev"
__url__ = "https://github.com/codemagic-ci-cd/cli-tools"
__licence__ = "GNU General Public License v3.0"
2 changes: 2 additions & 0 deletions src/codemagic/apple/resources/enums.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ class ContentRightsDeclaration(ResourceEnum):

class DeviceClass(ResourceEnum):
APPLE_TV = "APPLE_TV"
APPLE_VISION_PRO = "APPLE_VISION_PRO"
APPLE_WATCH = "APPLE_WATCH"
IPAD = "IPAD"
IPHONE = "IPHONE"
Expand All @@ -158,6 +159,7 @@ def is_compatible(self, profile_type: ProfileType) -> bool:
return self is DeviceClass.MAC
else:
return self in (
DeviceClass.APPLE_VISION_PRO,
DeviceClass.APPLE_WATCH,
DeviceClass.IPAD,
DeviceClass.IPOD,
Expand Down