Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting provisioning profile specifiers for specific SDKs #371

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Fix setting provisioning profile specifiers for specific SDKs #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b29f90
Update SDK specfic PROVISIONING_PROFILE_SPECIFIER entries
priitlatt Nov 8, 2023
8599855
Update changelog and bump version
priitlatt Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
Version 0.47.1
-------------

**Bugfixes**
- Update action `xcode-project use-profiles`. Fix assigning provisioning profiles to Xcode targets that have SDK specific provisioning profile specifiers. [PR #371](https://github.com/codemagic-ci-cd/cli-tools/pull/371)

Version 0.47.0
-------------

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "codemagic-cli-tools"
version = "0.47.0"
version = "0.47.1"
description = "CLI tools used in Codemagic builds"
readme = "README.md"
authors = [
Expand Down
2 changes: 1 addition & 1 deletion src/codemagic/__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
__title__ = "codemagic-cli-tools"
__description__ = "CLI tools used in Codemagic builds"
__version__ = "0.47.0.dev"
__version__ = "0.47.1.dev"
__url__ = "https://github.com/codemagic-ci-cd/cli-tools"
__licence__ = "GNU General Public License v3.0"
7 changes: 6 additions & 1 deletion src/codemagic/scripts/code_signing_manager.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ def set_automatic_build_settings(target, build_configuration, profile)
build_configuration.build_settings["DEVELOPMENT_TEAM"] = profile["team_id"]

build_configuration.build_settings.each do |build_setting, _value|
if build_setting.start_with? "CODE_SIGN_IDENTITY[sdk="
if build_setting.start_with?("CODE_SIGN_IDENTITY[sdk=", "PROVISIONING_PROFILE_SPECIFIER[sdk=")
build_configuration.build_settings.delete build_setting
end
end
Expand All @@ -255,6 +255,11 @@ def set_manual_build_settings(target, build_configuration, profile)
unless target.product_type == UNIT_TESTING_PRODUCT_TYPE
target_attributes[target.uuid]["ProvisioningStyle"] = "Manual"
build_configuration.build_settings["PROVISIONING_PROFILE_SPECIFIER"] = profile['name']
build_configuration.build_settings.each do |build_setting, _value|
if build_setting.start_with? "PROVISIONING_PROFILE_SPECIFIER[sdk="
build_configuration.build_settings[build_setting] = profile["name"]
end
end
end

build_configuration.build_settings["CODE_SIGN_IDENTITY"] = profile["certificate_common_name"]
Expand Down