Do not use xcpretty if it is not installed
#372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
xcode-projectactions use xcpretty to formatxcodebuildlogs by default. Currently it is not possible to use those actions ifxcprettyis missing on the system without specifying--disable-xcprettyoption. This is because the actions would automatically apply formatter without checking if it is available, and consequently crash.Check if
xcprettyis available on the machine where the action is executed any only then use it for formatting (unless it is disabled). Otherwise show an appropriate warning withxcprettyinstallation instructions and move on with the action without formattingxcodebuildlogs.Updated actions:
xcode-project cleanxcode-project build-ipaxcode-project run-tests