Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add certificate type mappings for all provisioning profile types #378

Merged

Conversation

priitlatt
Copy link
Contributor

Certificate type resolving from provisioning profile types MAC_CATALYST_APP_DEVELOPMENT, MAC_CATALYST_APP_STORE, MAC_CATALYST_APP_DIRECT, IOS_APP_INHOUSE and TVOS_APP_INHOUSE is not defined and as a result invoking CertificateType.from_profile_type with any of those fails with a ValueError:

Traceback (most recent call last):
  File "/Users/builder/.pyenv/versions/3.8.13/lib/python3.8/site-packages/codemagic/cli/cli_app.py", line 213, in invoke_cli
    CliApp._running_app._invoke_action(args)
  File "/Users/builder/.pyenv/versions/3.8.13/lib/python3.8/site-packages/codemagic/cli/cli_app.py", line 170, in _invoke_action
    return cli_action(**action_args)
  File "/Users/builder/.pyenv/versions/3.8.13/lib/python3.8/site-packages/codemagic/cli/cli_app.py", line 465, in wrapper
    return func(self, *args, **kwargs)
  File "/Users/builder/.pyenv/versions/3.8.13/lib/python3.8/site-packages/codemagic/tools/app_store_connect.py", line 1050, in fetch_signing_files
    certificates = self._get_or_create_certificates(
  File "/Users/builder/.pyenv/versions/3.8.13/lib/python3.8/site-packages/codemagic/tools/app_store_connect.py", line 1100, in _get_or_create_certificates
    certificate_types = [CertificateType.from_profile_type(profile_type)]
  File "/Users/builder/.pyenv/versions/3.8.13/lib/python3.8/site-packages/codemagic/apple/resources/enums.py", line 138, in from_profile_type
    raise ValueError(f"Certificate type for profile type {profile_type} is unknown")
ValueError: Certificate type for profile type MAC_CATALYST_APP_STORE is unknown

This PR defines missing mappings from profiles types to certificate types.

Updated actions:

  • app-store-connect fetch-signing-files
  • app-store-connect list-certificates

@priitlatt priitlatt marked this pull request as ready for review November 30, 2023 12:59
@priitlatt priitlatt added bug Something isn't working app-store-connect labels Nov 30, 2023
…gfix/mac-cataclyst-profile-type-certificate-type-mapping
@priitlatt priitlatt merged commit 9ade139 into master Dec 1, 2023
7 checks passed
@priitlatt priitlatt deleted the bugfix/mac-cataclyst-profile-type-certificate-type-mapping branch December 1, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-store-connect bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants