Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle for oauth2client errors in Google Play API client #379

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Nov 30, 2023

When executing Google Play API request fails with oauth2client.client.Error then the called action fails unexpectedly. For example:

$ google-play get-latest-build-number --package-name "com.example.app" --tracks "internal"
Get package "com.example.app" latest build number from track "internal"
Executing "google-play get-latest-build-number" failed unexpectedly. Detailed logs are available at "/var/folders/w2/rrf5p87d1bbfyphxc7jdnyvh0000gn/T/codemagic-29-11-23.log". To see more details about the error, add "--verbose" command line option.

Needless to say that this is cryptic for users and difficult to act upon. As a workaround handle those errors similarly to errors from googleapiclient.errors.

Updated actions:

  • All actions in tool google-play

@priitlatt priitlatt added the bug Something isn't working label Nov 30, 2023
@priitlatt priitlatt marked this pull request as ready for review November 30, 2023 13:57
@priitlatt priitlatt merged commit 39d4c62 into master Dec 1, 2023
7 checks passed
@priitlatt priitlatt deleted the bugfix/google-play-requests-error-handling branch December 1, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants