Allow custom export options for xcode-project build-ipa
#391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Xcode versions can introduce export options that are not defined in our
ExportOptions
class (for exampletestFlightInternalTestingOnly
that was added some time ago, but for which we were lacking definition).Also in general Xcode does not restrict usage of totally custom export options, and as such it makes little to no sense to be very strict about what keys are allowed in export options and what are not. This PR allows usage of export option keys that are not explicitly defined by the fields in
ExportOptions
class. Such fields are persisted when the object is updated and are included when the properly list is saved to disk.Updated actions
xcode-project build-ipa
Example log with warning about unknown export option