Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom export options for xcode-project build-ipa #391

Merged
merged 4 commits into from
Jan 12, 2024

Conversation

priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Jan 11, 2024

New Xcode versions can introduce export options that are not defined in our ExportOptions class (for example testFlightInternalTestingOnly that was added some time ago, but for which we were lacking definition).

Also in general Xcode does not restrict usage of totally custom export options, and as such it makes little to no sense to be very strict about what keys are allowed in export options and what are not. This PR allows usage of export option keys that are not explicitly defined by the fields in ExportOptions class. Such fields are persisted when the object is updated and are included when the properly list is saved to disk.

Updated actions

  • xcode-project build-ipa
Example log with warning about unknown export option
$ xcode-project build-ipa --project banaan.xcodeproj --archive-flags="-destination 'generic/platform=iOS'"
Warning: Using unknown export option "myInterestingCustomOption"
Using Xcode 15.2 (15C500b)

Check banaan.xcodeproj build settings
Execute "xcodebuild -project banaan.xcodeproj -scheme banaan -showBuildSettings"

...

@priitlatt priitlatt marked this pull request as ready for review January 11, 2024 10:11
@priitlatt priitlatt merged commit 3f84a65 into master Jan 12, 2024
7 checks passed
@priitlatt priitlatt deleted the improvement/allow-custom-export-options branch January 12, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants