Add support for interception against page refreshes #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
amitmbee
commented
Jun 19, 2018
amitmbee
commented
- Tested here, here and here
- Does not work on some websites due to caching (?) Not sure
revathskumar
approved these changes
Jun 22, 2018
amitmbee
commented
Jun 22, 2018
| @@ -167,7 +167,7 @@ class Intercept { | |||
| } | |||
| })();`; | |||
| let script = document.createElement("script"); | |||
| script.defer = true; | |||
| script.defer = false; | |||
There was a problem hiding this comment.
I was having one concern about this change. Does making make everypage load slower since this script has be loaded and executed before rendering the page iteself ?
There was a problem hiding this comment.
can you test this out and come up with some stats?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.