Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected text deletion on selection related to dead keys #6893

Closed
silverwind opened this issue Mar 9, 2022 · 1 comment
Closed

Unexpected text deletion on selection related to dead keys #6893

silverwind opened this issue Mar 9, 2022 · 1 comment

Comments

@silverwind
Copy link
Contributor

silverwind commented Mar 9, 2022 •
edited
Loading

On macOS with Browsers Firefox 99 or Safari 15 (but not in Chrome 99), there is a bug where Codemirror unexpectedly deletes content when accent characters like ` are present and when the current keyboard layout has that key as a dead key. Disabling the dead key in the keyboard layout eliminates the issue.

Here's an example of entering a text with backtick characters and then using the mouse to select the content via a drag action:

simple2

For comparison, a regular <textarea> does not show such issues:

simple3
@silverwind silverwind mentioned this issue Mar 9, 2022
Closed
@silverwind silverwind changed the title Unexpected text deletion on selection with combinator characters Unexpected text deletion on selection with accent characters like `` ``` Apr 5, 2022
@silverwind silverwind changed the title Unexpected text deletion on selection with accent characters like `` ``` Unexpected text deletion on selection with accent characters Apr 5, 2022
@silverwind silverwind changed the title Unexpected text deletion on selection with accent characters Unexpected text deletion related to dead keys Apr 8, 2022
@silverwind silverwind changed the title Unexpected text deletion related to dead keys Unexpected text deletion on selection related to dead keys Apr 8, 2022
@marijnh
Copy link
Member

marijnh commented Jul 27, 2022

Attached patch seems to help with this.

@marijnh marijnh closed this as completed Jul 27, 2022
silverwind added a commit to silverwind/gitea that referenced this issue Aug 20, 2022
@silverwind
Update codemirror on 1.17
ecfad6e 
Includes fix for codemirror/codemirror5#6893.
@silverwind silverwind mentioned this issue Aug 20, 2022
Merged
silverwind added a commit to silverwind/gitea that referenced this issue Aug 20, 2022
@silverwind
Update codemirror to 5.65.8
0397861 
Includes fix for codemirror/codemirror5#6893.
zeripath pushed a commit to go-gitea/gitea that referenced this issue Aug 21, 2022
@silverwind
Update codemirror to 5.65.8 (#20875)
17d3a47 
Includes fix for codemirror/codemirror5#6893.
@devnaumov devnaumov mentioned this issue Feb 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@silverwind @marijnh