Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix white CodeMirror-scrollbar-filler on dark themes #6882

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erosman
Copy link
Contributor

@erosman erosman commented Feb 18, 2022

Previously #6485

@marijnh
Copy link
Member

marijnh commented Feb 18, 2022

Won't that still make the element transparent whenever the editor itself is transparent?

@erosman
Copy link
Contributor Author

erosman commented Feb 18, 2022

Any other ideas?

The white square doesn't look good on dark theme, and even if transparent when editor is transparent, it would still look better than the white square. ;)

What about getting its background-color from the scrollbar background-color?!

@marijnh
Copy link
Member

marijnh commented Feb 18, 2022

I think adding a rule to color this class in the themes would be the best approach. A bit burdensome, but without using CSS variables (which some of our supported browsers don't have), I don't see a more convenient solution.

@erosman
Copy link
Contributor Author

erosman commented Feb 18, 2022

That would require the use of var() and @media screen and (prefers-color-scheme: light/dark) which is not supported by older browsers.

Even then, the color will not be a perfect match for all dark themes.

It doesn't bother me as I had already added background-color: inherit; to my own CSS and it works fine for my browser extension use.

I thought the less than ideal inherit might be more adaptable than the status que.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants