Missing @lezer/common transitive peer dependency of codemirror

[rtritto]

Describe the issue

@lezer/common is a peer depedency of @codemirror/autocomplete.
@codemirror/autocomplete is a dependency of codemirror.
codemirror must also include @lezer/common dependency.

Reproduction:

• yarn init -y
• yarn set version berry
• yarn add codemirror
• (optional) yarn explain peer-requirements and see logs

  p9f5f8 → ✘ codemirror@npm:6.0.1 doesn't provide @lezer/common to @codemirror/autocomplete@npm:6.12.0 [53c64]

• (detailed) yarn explain peer-requirements p9f5f8 and see logs

  Package codemirror@npm:6.0.1 is requested to provide @lezer/common by its descendants
  
  codemirror@npm:6.0.1
  └─ @codemirror/autocomplete@npm:6.12.0 [53c64] (via ^1.0.0)
  
  ✘ Package codemirror@npm:6.0.1 does not provide @lezer/common.

Workaround:

# .yarnrc.yml
packageExtensions:
  codemirror@*:
    dependencies:
      "@lezer/common": "*"

Browser and platform

No response

Reproduction link

No response

[marijnh]

@lezer/common is a peer depedency of @codemirror/autocomplete.

No, it's a regular dependency. And since codemirror does not reference it, it doesn't declare it.

Yarn making up new rules, or whatever is going on here, is not something I'm willing to concern myself with. I recommend using npm, which is a lot less broken at this point.

[rtritto]

@marijnh this missing dependency issue isn't related only with yarn. You can see logs also with npm and pnpm. I used yarn to get fast reproduction (detailed logs with commands instead of simple logs).
With any package manager you can do a clean install to get the warning issue in the logs.

package.json of@codemirror/autocomplete requires the @lezer/common dependency:

{
  "name": "@codemirror/autocomplete",
  "version": "6.18.3",
  "peerDependencies": {
    "@lezer/common": "^1.0.0"
  },
}

Simply add @lezer/common to package.json of codemirror:

{
  "name": "codemirror",
  "version": "6.0.1",
  "dependencies": {
+    "@lezer/common": "^1.2.3"
  },
}

If you dodn't know about transitive peer dependencies, this is an aricle: Implicit Transitive Peer Dependencies

[marijnh]

It looks like, at some point, I added a peerDependencies clause to @codemirror/autocomplete's package file as an experiment, and then forgot about it. Does removing it (as in the linked patch) resolve this warning?

[rtritto]

Does removing it (as in the linked patch) resolve this warning?

Yes, removing @lezer/common from peerDependencies in @codemirror/autocomplete will fix this issue.

[rtritto]

@marijnh please can you do a new release for the @codemirror/autocomplete package? Current version is 6.18.3.

[marijnh]

Sure. I've tagged 6.18.4