This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Support JCenter in Bootstrap Launcher #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Bootstrap Launcher was designed to download anything from Maven Central. But since commit 97e67cb has added JDA for Discord the Bootstrap Launcher was not able to download it because it along with some of its dependencies are only hosted on JCenter. This commit adds the ability to resolve dependencies from other repos, but currently only JCenter and Maven Central are used. It still tries to get anything from Maven Central and only uses JCenter, or any other repo that may be used in the future, as a fallback if Maven Central doesn't have a dependency.
…ncyList.txt source
|
Is |
|
Great pull request, thank you! dependencies.xml ist not ment to be commited. It would be even better to get the output of I will inspect your changes as soon as possible. |
|
I've managed to get the dependencies directly from sbt. See my latest commit. |
|
Great work! Tested your code, everything works fine and is well developed. Thank you for your help, we would love to welcome you on the code overflow discord server! |
|
No problem. Love how Chat Overflow progresses, as Code Overflow 1 was my main impuls to learn coding. |
hlxid
added a commit
to codeoverflow-org/chatoverflow-wiki
that referenced
this pull request
Jul 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Bootstrap Launcher was designed to download anything from Maven Central.
But since commit 97e67cb has added JDA for Discord the Bootstrap Launcher was not able to download it because it along with some of its dependencies are only hosted on JCenter.
This pr adds the ability to resolve dependencies from other repos, but currently only JCenter and Maven Central are used. It still tries to get anything from Maven Central and only uses JCenter, or any other repo that may be used in the future, when Maven Central doesn't have a dependency.
Any feedback would be appreciated.