Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

Split GUI into its own jar #109

Merged
merged 4 commits into from
Aug 7, 2019
Merged

Conversation

hlxid
Copy link
Member

@hlxid hlxid commented Aug 5, 2019

Closes #102 by modifying the package task to also create a jar for the GUI. Note that the gui task still has to be executed to actually build the GUI, package will just create a jar with the built GUI files.

Also adds a custom GUIServlet to serve the gui over the http server because jetty wasn't able to do it if the GUI isn't included in the same jar (at least to my testing).

I've also replaced the installGuiDeps and buildGui with a more general executeNpmCommand to increase code reuse, because the two previous methods were almost the same.

@hlxid hlxid added this to the pre-alpha 3 milestone Aug 5, 2019
@hlxid hlxid requested a review from sebinside August 5, 2019 15:33
@sebinside
Copy link
Member

Building the new gui jar works fine, including the deployment.

But when i try to start the framework from inside IntelliJ IDEA, i got the GUI couldn't be found on the classpath! Has the GUI been built? error message, although the jar is in the target folder. Am I missing something?

@hlxid
Copy link
Member Author

hlxid commented Aug 6, 2019

Try to reload the sbt configuration inside IntelliJ (sbt window > reimport) to let IntelliJ discover the new jar.
This is only required for the first time, similar to the required IntelliJ reload after the api has been fetched for the first time.

@sebinside
Copy link
Member

Wow, I did not think that the solution is that easy.

@sebinside sebinside merged commit 61f0665 into develop Aug 7, 2019
@sebinside sebinside removed their request for review August 7, 2019 10:26
@hlxid hlxid deleted the feature/102-gui-task-rework branch November 29, 2019 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants