Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

Add gui to the build process #17

Merged
merged 5 commits into from
Jun 16, 2019
Merged

Add gui to the build process #17

merged 5 commits into from
Jun 16, 2019

Conversation

hlxid
Copy link
Member

@hlxid hlxid commented Jun 15, 2019

Adds a task to sbt to build the gui and add it to the classpath. Jetty then serves the gui right from the classpath/jar. Meant to be a transition til the gui is packaged as a electron app.

Currently the gui is included in the jar of the main framework when deployed. Do you rather want it to be in a seperate jar only for the gui or is it fine in the main jar?

@sebinside
Copy link
Member

Thank you for this great idea! Until we have a standalone app (way in the future), this is a good solution.

While testing the code, I ran into two problems:

  • First, the (updated) custom intellij run configurations do not work properly, since the rely on the GUI-sbt-command, which has to be shared, too (checkbox in the upper right corner of the configuration)
  • I was not able to execute the gui sbt command in the IntelliJ windows sbt console, since npm could not be found, although it is abviously in the system path variable. I probably could fix this problem by injecting the npm path into the (missing) sbt gui run configuration mentioned above, but it would not fix the problem for other users. the error message is: java.io.IOException: Cannot run program "npm" (in directory "gui"): CreateProcess error=2, Das System kann die angegebene Datei nicht finden. Note, that this seems not to be yours but rather an IntelliJ problem (just google the error message). But we should still provide an alternative approach / solution for this...

@hlxid
Copy link
Member Author

hlxid commented Jun 16, 2019

@sebinside you can now test again. The solution was to execute npm through cmd to get access to the path.

Updated simple run configuration. Simple runs (e.g. in the plugin dev workflow) should not rebuild the GUI.
@sebinside
Copy link
Member

Now everything works fine. Successfully tested on windows and mac os. Thank you!

@sebinside sebinside merged commit e9d7d55 into codeoverflow-org:master Jun 16, 2019
@hlxid hlxid deleted the bundle-gui branch July 25, 2019 18:57
@hlxid hlxid mentioned this pull request Jul 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants