This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Adding RCON Connector #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Connector Can Send Message TODO: Error Catching Response from server
This was referenced Jun 27, 2019
Closed
sebinside
reviewed
Jul 2, 2019
src/main/scala/org/codeoverflow/chatoverflow/requirement/service/rcon/RconConnector.scala
Show resolved
Hide resolved
Fixed some typos in the README.md file.
If the channels aren't cleared and the connector is restarted multiple times it won't join into any channels that the connector has joined before the restart because it still thinks it has joined them already
Pass functions to register method from inputs instead of methods
J0B10
suggested changes
Jul 14, 2019
src/main/scala/org/codeoverflow/chatoverflow/requirement/service/rcon/RconConnector.scala
Show resolved
Hide resolved
src/main/scala/org/codeoverflow/chatoverflow/requirement/service/rcon/impl/RconInputImpl.scala
Outdated
Show resolved
Hide resolved
src/main/scala/org/codeoverflow/chatoverflow/requirement/service/rcon/impl/RconInputImpl.scala
Show resolved
Hide resolved
src/main/scala/org/codeoverflow/chatoverflow/requirement/service/rcon/impl/RconOutputImpl.scala
Show resolved
Hide resolved
src/main/scala/org/codeoverflow/chatoverflow/requirement/service/rcon/RconConnector.scala
Outdated
Show resolved
Hide resolved
Only pass true to start if start and login are succesful But than always start Impl Also quit if port is no valid number
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an RCON Connector for standard RCON protocols.
I used this protocol description of RCON, but it should work with every RCON compatible Game.
There is an Input Impl and an Output Impl.
Both have one function.
Input Impl has
getCommandOutput.Output Impl has
sendCommand.sendCommandwill just return if the command was sent successfully (Warning: RCON does never return if the command was executed successfully.).If returned
truethis means that the command should be tried executing by the server.It will return
falseif the Connection is not there (anymore) or the Authentication was unsuccessfully.getCommandOutputwill return the response to that command.It will return
nullif the Connection is not there (anymore) or the Authentication was unsuccessfully.This changes need a change in API, too. See PR 8 in API.
This will close issue #62