Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

Wait for authentication in twitch bot and report invalid credentials #86

Merged
merged 2 commits into from
Jul 12, 2019
Merged

Wait for authentication in twitch bot and report invalid credentials #86

merged 2 commits into from
Jul 12, 2019

Conversation

hlxid
Copy link
Member

@hlxid hlxid commented Jul 11, 2019

The framework needs to wait till the bot has authenticated, otherwise unexpected things like #80 happen. Waiting for auth is required anyway if we want to check if the credentials are correct (#27) which is also implemented in this pr.

@MelanX bitte teste ob dieser PR dein Problem löst.

Fixes #80 and fixes #27

hlxid added 2 commits July 11, 2019 18:27
If the channels aren't cleared and the connector is restarted multiple times
it won't join into any channels that the connector has joined before the
restart because it still thinks it has joined them already
@MelanX
Copy link
Contributor

MelanX commented Jul 11, 2019

Es funktioniert!

@sebinside
Copy link
Member

Develop or Master with hotfix pre alpha 2 Release? @joblo2213

@J0B10
Copy link
Member

J0B10 commented Jul 11, 2019

Master of course. It's a release!

@sebinside sebinside merged commit d9b137b into codeoverflow-org:develop Jul 12, 2019
@hlxid hlxid deleted the fix/80-twitch-wait-for-login branch July 13, 2019 07:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants