Skip to content
This repository was archived by the owner on Apr 13, 2025. It is now read-only.

Fix/npm workspaces #18

Merged
merged 2 commits into from
Oct 23, 2021
Merged

Fix/npm workspaces #18

merged 2 commits into from
Oct 23, 2021

Conversation

TimTechDev
Copy link
Contributor

  • Remove npm run bootstrap
  • Fix typos and grammar in README using https://languagetool.org/
  • Change test/uninstall/index.ts ls 35 because of change in api calls

Do not merge before codeoverflow-org/nodecg-io#268.

- Remove npm run bootstrap
- Fix typos and grammar in README using <https://languagetool.org/>
- Change test/uninstall/index.ts ls 35 because of change in api calls

Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
@hlxid hlxid self-requested a review October 21, 2021 14:50
Copy link
Member

@hlxid hlxid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, just two small improvements that could be made.

- Inline boolean in src/install/index
- Remove version check in src/install/dev
- Change `createDevInstall` test respectively

Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
Copy link
Member

@hlxid hlxid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hlxid hlxid changed the base branch from master to dev October 23, 2021 20:23
@hlxid hlxid merged commit 42b68fb into codeoverflow-org:dev Oct 23, 2021
@github-actions
Copy link

🎉 This PR is included in version 0.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@TimTechDev TimTechDev deleted the fix/npm-workspaces branch January 26, 2022 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants