Skip to content
This repository was archived by the owner on Apr 13, 2025. It is now read-only.

Publish current development version in some format that can be consumed by npm #235

Closed
hlxid opened this issue May 15, 2021 · 5 comments · Fixed by #328
Closed

Publish current development version in some format that can be consumed by npm #235

hlxid opened this issue May 15, 2021 · 5 comments · Fixed by #328
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@hlxid
Copy link
Member

hlxid commented May 15, 2021

Description

It would be nice if we could publish the current development version. That way we can generate bundles in the cli that can use those and you don't need to add your bundle, that relies on a development version, to the lerna.json (like in skates-bundles).

Some ideas on how me might do this:

  • push compilation results to a separate branch (force push, otherwise the repo might get too big)
  • push compilation results to a separate repository (with history and the possibility of publishing feature branches that are not master)
  • publish on the official npm registry with the next dist-tag (you get a email for each package publication with no opt-out, no please not)
  • publish npm tarballs
  • publish on github package registry (only viable if they figured out unauthenticated reads)

Not sure yet which route we're going with...

@hlxid hlxid added the enhancement New feature or request label May 15, 2021
@hlxid hlxid added this to the v0.2.0 milestone Jul 12, 2021
@vypxl
Copy link

vypxl commented Oct 12, 2021

An idea: What about Github build artifacts?
https://docs.github.com/en/actions/advanced-guides/storing-workflow-data-as-artifacts

@hlxid
Copy link
Member Author

hlxid commented Oct 13, 2021

Might be an option but GH Actions Artifacts has to my knowledge no way to always get the latest version with a static url. You would need to always update the url to include the id of an artifact of a recent run.

@TimTechDev
Copy link
Contributor

I would prefer option b)

push compilation results to a separate repository

@hlxid
Copy link
Member Author

hlxid commented Oct 24, 2021

Yeah, that's propably the way to go in combination with e.g. GitPkg because npm can't include a sub directory of a repository.
Having the ability to test feature branches is also kinda nice.

@hlxid hlxid modified the milestones: v0.2.0, v0.3.0 Nov 9, 2021
@hlxid
Copy link
Member Author

hlxid commented Nov 23, 2021

An advantage for publishing tarballs would be that we could publish the samples as tarballs too. We could then get them in the nodecg-io-cli in order to install them for production installations. We would still need to figure out how the TypeScript code can be built then, but we could more easily download the samples.

I don't really want to use an external service like GItPkg if I don't need to. I'm think for now we're going to do both: tarballs and the actual compilation results, so we can use what we want and still decide on one of them later. Unpacking the tarballs in the GItHub Actions step isn't too much of a hassle.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants