Skip to content
This repository was archived by the owner on Apr 13, 2025. It is now read-only.

Hide save button when selecting a non configurable service #218

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Hide save button when selecting a non configurable service #218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions nodecg-io-core/dashboard/serviceInstance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ const instanceMonaco = document.getElementById("instanceMonaco");
let editor: monaco.editor.IStandaloneCodeEditor | undefined;

const spanInstanceNotice = document.getElementById("spanInstanceNotice");
const buttonSave = document.getElementById("buttonSave");

// HTML Handlers

Expand Down Expand Up @@ -62,12 +63,12 @@ export function onInstanceSelectChange(value: string): void {
switch (value) {
case "new":
showInMonaco("text", true, editorCreateText);
setCreateInputs(true, false);
setCreateInputs(true, false, true);
inputInstanceName.value = "";
break;
case "select":
showInMonaco("text", true, editorDefaultText);
setCreateInputs(false, false);
setCreateInputs(false, false, true);
break;
default:
showConfig(value);
Expand All @@ -87,7 +88,7 @@ function showConfig(value: string) {
showInMonaco("json", false, jsonString, service?.schema);
}

setCreateInputs(false, true);
setCreateInputs(false, true, !(service?.requiresNoConfig ?? false));
}

// Save button
Expand Down Expand Up @@ -207,7 +208,7 @@ function selectServiceInstance(instanceName: string) {
}

// Hides/unhides parts of the website based on the passed parameters
function setCreateInputs(createMode: boolean, instanceSelected: boolean) {
function setCreateInputs(createMode: boolean, instanceSelected: boolean, showSave: boolean) {
function setVisible(node: HTMLElement | null, visible: boolean) {
if (visible && node?.classList.contains("hidden")) {
node?.classList.remove("hidden");
Expand All @@ -220,6 +221,7 @@ function setCreateInputs(createMode: boolean, instanceSelected: boolean) {
setVisible(instanceCreateButton, createMode);
setVisible(instanceNameField, createMode);
setVisible(instanceServiceSelector, createMode);
setVisible(buttonSave, showSave);
}

export function showNotice(msg: string | undefined): void {
Expand Down