This repository was archived by the owner on Apr 13, 2025. It is now read-only.
elgato-light service for Keylights and light stripes. #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlxid
approved these changes
Sep 25, 2021
There was a problem hiding this comment.
I've refactored the createLightData method to take an object in 0a84989, I hope you're fine with that. This makes it more clear what a call to it does because the parameter name is right in the call and you don't have to lookup its signature.
Apart from that this looks good to me.
hlxid
added a commit
to codeoverflow-org/nodecg-io-docs
that referenced
this pull request
Oct 1, 2021
Adds sample documentation for elgato light service (codeoverflow-org/nodecg-io#247).
hlxid
added a commit
to codeoverflow-org/nodecg-io-docs
that referenced
this pull request
Nov 3, 2021
* Add sample doc for elgato light service Adds sample documentation for elgato light service (codeoverflow-org/nodecg-io#247). * Update elgato-light sample doc to adhere to new template
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #118. Does not use any external elgato light npm library because the're are all not up to date and we only need two HTTP requests...