This repository was archived by the owner on Apr 13, 2025. It is now read-only.
Implement localhost default address for IntelliJ service config
#250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IntelliJ schema mentions that it defaults to `127.0.0.1:19524` if no address is given. This makes sense as most will connect the service to the IntelliJ instance running on the same host. However the schema requires a value and also the code doesn't check for `undefined` and thus doesn't provide the default if the value is missing. This PR implements the default value by using it if no value is provided and removing `address` from the required fields list of the JSON schema.
… address in config
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IntelliJ schema mentions that it defaults to
127.0.0.1:19524if no address is given.This makes sense as most will connect the service to the IntelliJ instance running on the same host.
However the schema requires a value and also the code doesn't check for
undefinedand thus doesn't provide the default if the value is missing.This PR implements the default value by using it if no value is provided and removing
addressfrom the required fields list of the JSON schema.