Skip to content
This repository was archived by the owner on Apr 13, 2025. It is now read-only.

Implement an Art-Net service into nodecg-io #257

Merged
merged 4 commits into from
Oct 12, 2021
Merged

Implement an Art-Net service into nodecg-io #257

merged 4 commits into from
Oct 12, 2021

Conversation

TimTechDev
Copy link
Contributor

closes #48

- Add service from <github.com/jeffreykog/node-artnet-protocol>
- ~~Add custom typings~~ ++switched library++
- REDME Update
- Add sample
- Add documentation

closes #48
Copy link
Member

@hlxid hlxid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this in advance.

- Use nodecg-types
- Fix typo in artnetServiceClient.ts
- Remove host from required from artnet-schema.json
Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
- Use nodecg-types (now really)

Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
@TimTechDev TimTechDev requested a review from hlxid October 12, 2021 18:58
Copy link
Member

@hlxid hlxid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlxid hlxid merged commit e6f1880 into codeoverflow-org:master Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Art-Net and sACN Integration
2 participants