This repository was archived by the owner on Apr 13, 2025. It is now read-only.
Add Shlink service & sample bundle #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlxid
reviewed
Oct 13, 2021
There was a problem hiding this comment.
Looks good to me, thanks!. Just please fix the two linter warnings. You can see them by running npm run lint or in the Files changed tab on this Pull Request.
Yeah the documentation on creating a service is outdated. The currently best way to create a new service usingt this script. The documentation just wasn't updated yet to use this script.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shlink
I hope everything is fine 😃; I followed the setup of other services, because the documentation seems a little bit outdated (e.g. the versions of the dependecies).