Add Log Prefix for logs in an instance

[ExtremTechniker]

with custom logger
Move all necessary functions from nodecg.log to logger

[ExtremTechniker]

Closes #155

[hlxid]

Looks pretty good to me. Please resolve the merge conflicts as described in the guide you got on discord. I can resolve the conflicts aswell, if you need help.

[TimTechDev]

As you asked over on our discord how to resolve merge conflicts, I thought I could help you. So here we go:

Merge conflicts are a result of editing the same piece of code in two different branches, which you want to merge again. So the simplest solution is to merge the current https://github.com/codeoverflow-org/nodecg-io/master-branch into your feature-branch.

• Add https://github.com/codeoverflow-org/nodecg-io.git to your git remotes
• Merge upstream/master into your feature branch
• Resolve conflicts

E.g., take a look at the diff of services/nodecg-io-twitch-api/extension/index.ts:

<<<<<<< HEAD (Current Change)
import { Result, emptySuccess, success, ServiceBundle, Logger } from "nodecg-io-core";
import { ApiClient } from "twitch";
=======
import { Result, emptySuccess, success, ServiceBundle } from "nodecg-io-core";
import { ApiClient } from "@twurple/api";
>>>>>>> upstream/master (Incoming Change)

You added the logger to the imports, while Daniel bumped the version of the Twitch API. So to resolve this, you would either add the logger to the Incoming Change or the updated the dependency in the Current Change.

Then push everything to your branch.

[TimTechDev]

You may take a look at TimTechDev@987b4f5.

[ExtremTechniker]

@daniel0611 Could you please resolve these merge conflicts, because I do not have write accesses to do this. Thanks!

[hlxid]

Sure, no problem! You actually succesfully merged the master branch but there we other changes and thus more conflicts.

[TimTechDev]

I want to mention that there are 4 test cases failing.

[hlxid]

Yeah. These failures are because the logger is now passed to createClient etc. and the current test check for the passed arguments for the config. I'll fix them soon.
Wondering if these test failures were here before the merge. I can't remember.

[TimTechDev]

Wondering if these test failures were here before the merge. I can't remember.

Yes, I think so checked on 8b823f3

Also, I looked at this commit history and want to mention that this will cause problems with git blame and other tools, because the contents of the master branch got duplicated.
edit:
This is also why there were merge conflicts, that were not resolvable by @ExtremTechniker.

[hlxid]

What do you mean with "duplicated"? Because of 755ae35? GitHub shows the new changes from the other branch in merge commits that resolved conflicts. This is not the case when using git diff locally and blame is still working fine on this branch aswell: https://github.com/codeoverflow-org/nodecg-io/blame/9ea7a6b6d138e3960892828eb47cb41bfa4bf59f/services/nodecg-io-ahk/extension/index.ts
Anyways I'm gonna squash merge this PR for cleaner history becasue of the 4 fixup commits.