This repository was archived by the owner on Apr 13, 2025. It is now read-only.
Feature: Update nodecg-io-streamelements to include test events #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also yes, we require a 2.x.x version of the socket-io-client because streamelements hasn't updated their service and v3+ doesn't work with 2.x.x connections |
|
Dang 🤦. How many times did I accidentially upgrade the socket.io lib to 3.0.0 or higher? Propably too often, lol. |
hlxid
reviewed
Nov 5, 2021
| } | ||
| }, | ||
| "required": ["jwtToken"] | ||
| "required": ["jwtToken", "handleTestEvents"] |
There was a problem hiding this comment.
I think it would be better if handleTestEvents defaults to false instead of requiring it here
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "streamelements-events", | |||
| "version": "0.2.0", | |||
| "version": "0.2.1", | |||
There was a problem hiding this comment.
I don't really mind having 0.2.1 here, but 0.2.0 wasn't released yet and it would be kinda weird if we start with 0.2.1 when we're going to release 0.2 sometimes in the future. I think I'm gonna push some features of the 0.2 milestone into 0.3 so we can release all the new services.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new field
handleTestEventsto the SE config which controls whether it should also fire test events.Also bumps the version to
0.2.1for the sample and nodecg-io-streamelements