This repository was archived by the owner on Apr 13, 2025. It is now read-only.
Disable deprecated automatic promise cancellation in telegram #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #267 Previously the telegram library automatically would enable bluebird promise cancellation. It is recommended to set the `NTBA_FIX_319` environment variable to disable automatic activation and only enable it if needed. We don't use promise cancellation arround here and anyone using our telegram service propably doesn't either. If this is the case they should enable it themselfs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #267
Previously the telegram library automatically would enable bluebird promise cancellation. It is recommended to set the
NTBA_FIX_319environment variable to disable automatic activation and only enable it if needed. We don't use promise cancellation arround here and anyone using our telegram service propably doesn't either. If this is the case they should enable it themselfs.