This repository was archived by the owner on Apr 13, 2025. It is now read-only.
Use https to clone the reddit dependencies #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into reddit_deps � Conflicts: � package-lock.json � services/nodecg-io-reddit/package.json
hlxid
approved these changes
Feb 11, 2022
Member
hlxid
left a comment
hlxid
left a comment
There was a problem hiding this comment.
Thanks! NodeCG bundles can use released versions of nodecg-io through yarn, as far as I know.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing noeppi-noeppi/npm-reddit-ts#1, I found out that yarn apparently has problems cloning the git repo via ssh. I don't know whether nodecg-io even can be used with yarn but I think making it use https explicitly should not be a problem, so I don't see a reason not to.