Skip to content
This repository was archived by the owner on Apr 13, 2025. It is now read-only.

Priorize exact midi device name match in case of an ambiguous pattern #531

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

hlxid
Copy link
Member

@hlxid hlxid commented Mar 30, 2022

@voruti
Copy link
Contributor

voruti commented Mar 30, 2022

Tested in new installation. Works for me. Thanks!

@hlxid hlxid merged commit 0b9e78a into main Mar 31, 2022
@hlxid hlxid deleted the fix/midi-multiple-matches branch March 31, 2022 04:25
deviceName = config.device;
} else {
// Otherwise we find a device which contains the pattern.
easymidi.getOutputs().forEach((device) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: Should be

easymidi.getInputs().forEach((device) => {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦. Fixed with #550

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants