This repository was archived by the owner on Apr 13, 2025. It is now read-only.
Downgrade socket.io types to same version that nodecg uses #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version `1.8.1` of our typings you will get an error if you want to use a `NodeCG` instance from these typings somewhere where a `NodeCG` instance of the official typings is expected. This happend because the types of the returned socker.io servers (from `NodeCGServer.getSocketIOServer()`) would differ. Before this PR this package uses the `3.x` series which are just stubs because with these versions socket.io bundles their own definitions. To fix this and get the same typings we need to depend on the same socket.io typings from version 2.x/1.x. Will be released as version `1.8.2`.
hlxid
added a commit
to codeoverflow-org/nodecg-io
that referenced
this pull request
Sep 25, 2021
Check codeoverflow-org/nodecg-types#1 for details
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version
1.8.1of our typings you will get an error if you want to use aNodeCGinstance from these typings somewhere where aNodeCGinstance of the official typings is expected. This happend because the types of the returned socker.io servers (fromNodeCGServer.getSocketIOServer()) would differ.Before this PR this package uses the
3.xseries which are just stubs because with these versions socket.io bundles their own definitions.To fix this and get the same typings we need to depend on the same socket.io typings from version 2.x/1.x.
Will be released as version
1.8.2.