feat(lambda)!: create lambda from a container image #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mskrajnowski
requested review from
cq-fpietron,
karwer,
TarasJan and
Aritzaranburu
karwer
approved these changes
Jan 27, 2021
lambda/README.md
Outdated
| * `image` (`string`, default: `null`) | ||
|
|
||
| URI of a container image with the Lambda's source. Either `package_path`, `package_s3` or `image` is required. | ||
|
|
||
| * `layer_qualified_arns` (`list(string)`, default: `[]`) |
There was a problem hiding this comment.
Can Lambda layers coexist with the container based function? If not, should we care about some validation for this?
There was a problem hiding this comment.
I'd expect AWS to throw an error if you try to use an image along with lambda layers, but haven't tested that yet.
There was a problem hiding this comment.
fixed in 46c2f69
mskrajnowski
force-pushed
the
feat/lambda-sources
branch
from
76c00b4 to
1c986b9
Compare
This reverts commit 746c740.
mskrajnowski
force-pushed
the
feat/lambda-image
branch
2 times, most recently
from
c6f5b31 to
e6e45ea
Compare
mskrajnowski
force-pushed
the
feat/lambda-image
branch
from
e6e45ea to
e611b19
Compare
minimizes the impact of hashicorp/terraform-provider-aws#15952
so you can disable publishing versions, eg. as a workaround for the perpetual diff problem
as a workaround for the perpetual diff problem
mskrajnowski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imageinput tolambdapublishinput tolambda, which let's you disable version publishing as a workaround for [REGRESSION] v3.13.0 causes perpetual diff of resources containing lambda version number hashicorp/terraform-provider-aws#15952rds/postgres/management_lambdasince we don't really need it to be versionedlambdamodule so that it only adds avpc_configblock when needed as another workaround for [REGRESSION] v3.13.0 causes perpetual diff of resources containing lambda version number hashicorp/terraform-provider-aws#15952Requires AWS provider 3.19+, which sadly contains hashicorp/terraform-provider-aws#15952. Added some workaround suggestions to
lambdamodule's readme.Breaking Changes:
lambdamodule now requires AWS provider 3.19+