-
Notifications
You must be signed in to change notification settings - Fork 7
Migrate the Frontend Coder Plugin to NFS #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Camila Belo <camilaibs@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
Signed-off-by: Camila Belo <camilaibs@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is used by "msw" to intercept requests that should be mocked by the Backstage dev app, such as requests to Coder Proxy API. The mock service worker needs to be in this "public" folder so that the Backstage CLI can find it and serve it at localhost:3000/mockServiceWorker.js
.
factory(originalFactory, context) { | ||
const { defaultQueryFilter, readEntityData } = context.config; | ||
return originalFactory({ | ||
filter: { kind: 'component' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This filter specifies that the card should be displayed for all entities of the component kind. Is there any specific entity spec
that must also be present in the entity data for the card to be displayed?
Signed-off-by: Camila Belo <camilaibs@gmail.com>
Description
This pull request migrates the Coder frontend plugin to support the new Backstage frontend system.
After merging this pull request it would be nice to: