🤖 Configure ESLint to only show errors, add manual dead code check #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Configure ESLint to treat warnings as errors (--max-warnings 0) - Fix outstanding ESLint warnings in ChatInput.tsx and telemetry/utils.ts - Add `make check-deadcode` target for manual dead code detection - Uses ts-prune with sensible filtering - NOT included in static-check (advisory only, not a hard requirement) - Filters out test/debug/storybook files and legitimate public APIs - Remove 563 lines of actual dead code identified by ts-prune Dead code removed: - TypewriterText component (unused) - ToolsTab component (unused) - Duplicate git functions in git.ts (gitService.ts has the implementations) - Various unused utility functions and types across the codebase Why manual-only dead code checking: - Line-number-based allowlists are brittle (break on any code change) - Hard to distinguish legitimate public API exports from actual dead code - Dead code is technical debt but not a correctness issue - Manual checking is still valuable for cleanup efforts _Generated with `cmux`_
|
✅ All checks pass locally:
CI jobs are timing out at exactly 10 minutes due to AWS outage. Will need to re-run once infrastructure recovers. Generated with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Configures ESLint to treat warnings as errors and adds a manual dead code checking command. Also removes 506 lines of actual dead code identified by ts-prune.
Changes
ESLint Configuration
--max-warnings 0flag to treat all warnings as errorsChatInput.tsx(missing deps) andtelemetry/utils.ts(unsafe any access)Dead Code Checking
make check-deadcodetarget for manual dead code detection using ts-prunestatic-check- advisory only, not a hard requirementDead Code Removal (506 lines)
TypewriterTextcomponent (unused)ToolsTabcomponent (unused)git.ts(implementations exist ingitService.ts)Why Manual-Only Dead Code Checking?
Automatic dead code checking in CI is too brittle:
Manual checking with
make check-deadcodeis still valuable for cleanup efforts without blocking CI.Generated with
cmux