Add server command to the entrypoint
#353
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import { Config } from "./config"; | ||
| import { IPC_CHANNELS } from "@/constants/ipc-constants"; | ||
| import { IpcMain } from "./services/ipcMain"; | ||
| import cors from "cors"; |
There was a problem hiding this comment.
cors and ws dependencies for server entrypoint
The new server entrypoint imports cors and ws to expose HTTP and WebSocket APIs, but package.json only adds express. Because those modules are never declared as dependencies, executing node dist/main.js server will immediately fail with MODULE_NOT_FOUND for the missing packages. They need to be added to dependencies (and type packages if required) so the server command can start.
Useful? React with 👍 / 👎.
This allows cmux to run as a web server. Run `node dist/main.js server` to start on port 3000.
There was a problem hiding this comment.
Would it make sense to add a visual storybook test for this component?
There was a problem hiding this comment.
probably i'll add later
2 participants
This allows cmux to run as a web server.
Run
node dist/main.js serverto start on port 3000.This directory select modal appears only when in browser mode for opening a new project. Everything else is the same.