Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a service-worker to enable caching and desktop PWA #138

Closed
lucacasonato opened this issue Mar 8, 2019 · 5 comments
Closed

Add a service-worker to enable caching and desktop PWA #138

lucacasonato opened this issue Mar 8, 2019 · 5 comments
Labels
enhancement Some improvement that isn't a feature
Milestone

Comments

@lucacasonato
Copy link
Contributor

lucacasonato commented Mar 8, 2019

On slow connections code-server takes ages to load the main JS bundle file, as it is multiple megabytes large. When reloading the page the bundle file has to get loaded again unless the browser locally caches it, which is not certain. It would drastically improve the experience if a service-worker would cache all of the necessary html, css, and JS bundles.

In combination with a web-manifest this would also enable code-server to be installed on client devices as PWA's. This is especially useful for desktop as you would not have to install a thin client. Using a PWA would also enable code-server to eventually implement features such as share-target to upload files onto the remote container.

This would require a very minimal amount of work for a very very useful feature, especially when you use Workbox.

@foresthoffman foresthoffman added the enhancement Some improvement that isn't a feature label Mar 8, 2019
@kylecarbs
Copy link
Member

I definitely agree. We'll do this!

@kylecarbs kylecarbs added this to the Backlog milestone Mar 8, 2019
@nhooyr nhooyr added the perf label Mar 8, 2019
@lucacasonato
Copy link
Contributor Author

If I find some time today I'll look into setting up the manifest file.

@lucacasonato
Copy link
Contributor Author

#154 should fix this

@sondresorbye
Copy link

This would also make the top bar in chrome dissapear on android devices.

@lucacasonato
Copy link
Contributor Author

merged in #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

No branches or pull requests

5 participants