Installing extensions from vsix tries to query marketplace

[Leletir]

Hello,

First of all thank you for your work !

I am trying to install extensions with local .vsix files downloaded for Microsoft marketplace since my build servers cannot access internet (company policies).

Since 3.7.2, I cannot install extensions without this error:

#9 28.35 Installing extensions...
#9 28.94 Extension 'eamodio.gitlens-11.0.2.vsix' was successfully installed.
#9 28.95 error vscode getaddrinfo ENOTFOUND extensions.coder.com
#9 28.95 error vscode Error: getaddrinfo ENOTFOUND extensions.coder.com

Here is the install process (via Docker):

RUN yum install -y /tmp/code-server-${CODE_SERVER_VERSION}-amd64.rpm \
    && mkdir -p ${CODE_SERVER_EXTENSIONS_DIRPATH} \
    && chmod -R 755 ${CODE_SERVER_EXTENSIONS_DIRPATH} \
# Install Extensions
    && code-server --extensions-dir ${CODE_SERVER_EXTENSIONS_DIRPATH} --install-extension /tmp/extensions/eamodio.gitlens-11.0.2.vsix 

• Remote OS: Rhel 7.6
• Remote Architecture: amd64
• code-server --version: 3.7.2

It seems that the extensions install process is trying to contact extensions.coder.com which is denied on my servers.
Is it a bug or I'm missing something on the extension's install process ?

Thank in advance for your answers.

Have a good day !

[code-asher]

I'm not sure; apparently even installing extensions locally tries to ping the extension marketplace. Maybe it's to get metadata or see if it's the latest version? I've been meaning to look into it but I haven't had a chance yet.

[Leletir]

Okay thank you for your feedback, but before 3.7.2 it does not make the installation failed

[code-asher]

before 3.7.2 it does not make the installation failed

Oh interesting! Sounds like it could be a bug with the new version then.

[Leletir]

Yes it could, I just verified with the versions 3.5.0, 3.6.2, 3.7.1, and it works with all these ones

[benz0li]

With v3.7.3 and v3.7.2, Installing an extension using command code-server --install-extension xyz.vsix leads to the following error:

Installing extensions...
Extension 'xyz' was successfully installed.
error vscode Server returned 500
error vscode Error: Server returned 500
    at Object.t.asJson (/opt/code-server/lib/vscode/out/vs/server/entry.js:373:933)
    at j.queryGallery (/opt/code-server/lib/vscode/out/vs/server/entry.js:393:695)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async j.query (/opt/code-server/lib/vscode/out/vs/server/entry.js:392:642)
    at async j.getExtensions (/opt/code-server/lib/vscode/out/vs/server/entry.js:390:251)
    at async /opt/code-server/lib/vscode/out/vs/server/entry.js:541:148
    at async Promise.all (index 0)
    at async J.getGalleryExtensions (/opt/code-server/lib/vscode/out/vs/server/entry.js:541:117)
    at async Promise.all (index 0)
    at async J.installExtensions (/opt/code-server/lib/vscode/out/vs/server/entry.js:540:13)
    at async J.run (/opt/code-server/lib/vscode/out/vs/server/entry.js:538:205)
    at async /opt/code-server/lib/vscode/out/vs/server/entry.js:545:678
    at async process.<anonymous> (/opt/code-server/lib/vscode/out/vs/server/entry.js:553:669)

This error does not occur with v3.7.1, though.

[ppkwiatkowski]

@benz0li @code-asher I confirm that installing extensions from .vsix in 3.7.3 ends with the above error, despite the Extension xxx was successfully installed msg showing up too

[Stradivario]

I am having the same issue with 3.7.3.

Downgrading to 3.7.1 and everything is up and running

Installing extensions...
Extension 'lit-plugin-1.2.0.vsix' was successfully installed.
error vscode Server returned 500
error vscode Error: Server returned 500
    at Object.t.asJson (/usr/lib/code-server/lib/vscode/out/vs/server/entry.js:373:933)
    at j.queryGallery (/usr/lib/code-server/lib/vscode/out/vs/server/entry.js:393:695)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async j.query (/usr/lib/code-server/lib/vscode/out/vs/server/entry.js:392:642)
    at async j.getExtensions (/usr/lib/code-server/lib/vscode/out/vs/server/entry.js:390:251)
    at async /usr/lib/code-server/lib/vscode/out/vs/server/entry.js:541:148
    at async Promise.all (index 0)
    at async J.getGalleryExtensions (/usr/lib/code-server/lib/vscode/out/vs/server/entry.js:541:117)
    at async Promise.all (index 0)
    at async J.installExtensions (/usr/lib/code-server/lib/vscode/out/vs/server/entry.js:540:13)
    at async J.run (/usr/lib/code-server/lib/vscode/out/vs/server/entry.js:538:205)
    at async /usr/lib/code-server/lib/vscode/out/vs/server/entry.js:545:678
    at async process.<anonymous> (/usr/lib/code-server/lib/vscode/out/vs/server/entry.js:553:669)
The command '/bin/sh -c code-server --install-extension "/home/coder/vscode_extensions/lit-plugin-1.0.2.vsix"' returned a non-zero code: 1

[code-asher]

I'll be looking into this soon. Just as an FYI, it's best to avoid 3.7.1: https://github.com/cdr/code-server/releases/tag/v3.7.2

[benz0li]

Workaround for error vscode Server returned 500:

code-server --install-extension xyz.vsix || true

---

You can also use the standard bash ignore error || true, which is nice if you are in the middle of a chain:

– https://stackoverflow.com/a/53520372

[code-asher]

Seems it's fixed upstream, just need to wait for the next release so we can pull it in: microsoft/vscode#110574

[snirbenyosef]

any news on that ? does 3.7.4 works with extensions ?

[Leletir]

Not yet, but the bug is resolved in VSCode

[meitalpa]

was this fixed? does 3.7.4 works with extensions?

[code-asher]

No, this was fixed in version 1.52.0 of VS Code which we haven't updated to yet.

[jc16180]

Did this get fixed by the latest release?

[Leletir]

Hello, I've tested in 3.9.0 and the issue it's resolved !
Thanks !

[code-asher]

Ah yup should be resolved now.