Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builtin extensions always require reload #4600

Closed
jsjoeio opened this issue Dec 10, 2021 · 3 comments · Fixed by #4680
Closed

Builtin extensions always require reload #4600

jsjoeio opened this issue Dec 10, 2021 · 3 comments · Fixed by #4680
Assignees
@code-asher
Labels
bug Something isn't working
Milestone
4.0.1

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 10, 2021 •
edited
Loading

@bpmct found an issue with the extensions panel while testing the 4.0.0 release.

Steps to Reproduce

  1. run code-server with 0 extensions installed
# create an empty directory
# that way we don't have to uninstall all extensions
mkdir empty-dir
code-server --extensions-dir empty-dir
  1. open extensions panel

Expected

See list of Popular Extensions
image

Actual (v3.12.0)

Works as expected.

image

Actual (v4.0.0)

Works as expected (running in dev mode with yarn watch)

image

Actual (vscode.dev)

Works as expected.

image

Actual (Codespaces)

🐛 Does not show Popular Extensions

image

Actual (VS Code)

Works as expected.

image
@jsjoeio jsjoeio added the bug Something isn't working label Dec 10, 2021
@jsjoeio jsjoeio added this to the 4.0.1 milestone Dec 10, 2021
@jsjoeio jsjoeio mentioned this issue Dec 10, 2021
Merged
21 tasks
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 10, 2021

We don't think this is an issue but will retest after 4.0.0 is out.

@jsjoeio jsjoeio modified the milestones: 4.0.1, 4.0.0 Dec 13, 2021
@benz0li
Copy link
Contributor

benz0li commented Dec 13, 2021 •
edited
Loading

Actual (https://vscode-r.jupyter.b-data.ch, v4.0.0, empty ~/.local/share/code-server/extensions)

Shows popular extensions. Says 'Reload Required' for builtin extension; pre-installed extensions* not affected.

*Pre-installed using code-server --extensions-dir /opt/code-server/vendor/modules/code-oss-dev/extensions --install-extension ms-python.python for example.

popular-extensions

@code-asher code-asher self-assigned this Dec 13, 2021
@code-asher code-asher changed the title Patch popular extensions bug Bulitin extensions always require reload Dec 17, 2021
@code-asher code-asher changed the title Bulitin extensions always require reload Builtin extensions always require reload Dec 17, 2021
@code-asher code-asher mentioned this issue Dec 20, 2021
Merged
code-asher added a commit to coder/vscode that referenced this issue Dec 23, 2021
@code-asher
Bypass spurious reload button (#32)
69a6ce4 
This reload button does nothing which I think must mean there is some
logic somewhere that is supposed to load these extensions locally that
is not working or not implemented.

Until we find it bypassing is probably a good move because otherwise it
makes it look like the extension is not running and working even though
it really is (it is just running remotely).

This will be a temporary measure to solve
coder/code-server#4600.
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jan 3, 2022

Fixed via coder/vscode#32

@jsjoeio jsjoeio closed this as completed Jan 3, 2022
code-asher added a commit to code-asher/code-server that referenced this issue Jan 4, 2022
@code-asher
Update VS Code
9c7c213 
Fixes coder#4598
Fixes coder#4620
Fixes coder#4600
@code-asher code-asher mentioned this issue Jan 4, 2022
Merged
code-asher added a commit that referenced this issue Jan 4, 2022
@code-asher
chore: update vscode (#4680)
f04fcf2 
* Update VS Code

Fixes #4598
Fixes #4620
Fixes #4600

* Add locale flag back

This is valid again now that we have restored display language support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@code-asher code-asher

Labels
bug Something isn't working
Projects
None yet
Milestone
4.0.1
Development

Successfully merging a pull request may close this issue.

chore: update vscode code-asher/code-server
3 participants
@jsjoeio @benz0li @code-asher