You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I didn't realize this but our release-prep.sh script will accidentally update
all strings in the package.json that match the version udpate.
This means if a dependency is 4.0.0 and we're upgrading code-server to 4.0.1,
our script updates the dependency too.
Oops. Documented here: #4679
I didn't realize this but our release-prep.sh script will accidentally update
all strings in the package.json that match the version udpate.
This means if a dependency is 4.0.0 and we're upgrading code-server to 4.0.1,
our script updates the dependency too.
Oops. Documented here: #4679
Problem
When we prep a release, we run a script locally called
release-prep.sh
.In it, there is a line that uses
rg
andsd
to bump the version across the project (i.e. 4.0.0 -> 4.0.1).Unfortunately, this means if there is a dependency with the same version we're bumping, it will bump that too 😅
Here is the exact line where we do this:
https://github.com/coder/code-server/blob/main/ci/build/release-prep.sh#L84
Example
Solution
It might be worth breaking this into two lines:
rg
->sd
replaces the first instance inpackage.json
package.json
but updates the other files (i.e. markdown)To summarize, we should split the current functionality into two calls:
package.json
(only first string it finds)The text was updated successfully, but these errors were encountered: