[Bug]: terminal not opening on 4.9.0 on macOS (github release and homebrew)

[jsjoeio]

Is there an existing issue for this?

• I have searched the existing issues

OS/Web Information

• Web Browser: Chrome
• Local OS: macOS
• Remote OS: macOS
• Remote Architecture: n/a
• code-server --version: 4.9.0

Steps to Reproduce

1. brew upgrade code-server
2. code-server
3. open Integrated Terminal

Expected

The terminal should load

Actual

It doesn't load

Logs

  ERR TypeError: Cannot read properties of undefined (reading 'cell')
    at c.getFont (terminalConfigHelper.ts:188:73)
    at Ui.getFont (xtermTerminal.ts:416:29)
    at Ki._getDimension (terminalInstance.ts:698:40)
    at Ki._evaluateColsAndRows (terminalInstance.ts:649:26)
    at Ki.layout (terminalInstance.ts:1875:30)
    at Ki._open (terminalInstance.ts:1072:9)
    at Ki.setVisible (terminalInstance.ts:1350:9)
    at g.setInput (terminalEditor.ts:78:39)
    at async a.doSetInput (editorPanes.ts:353:4)
    at async a.doOpenEditor (editorPanes.ts:222:34)

Screenshot/Video

Does this issue happen in VS Code or GitHub Codespaces?

• I cannot reproduce this in VS Code.
• I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over HTTPS?

• I am using HTTPS.

Notes

No response

[jsjoeio]

First thought is to test the macOS binary in the releases to see if this is specific to using code-server on Homebrew.

[jsjoeio]

Confirmed also broken on macOS release.

[jsjoeio]

However, it is working on Linux so that's good.

I'll check npm next.

[jsjoeio]

npm is also broken, which means anyone on AUR or Homebrew will also have a broken terminal

[jsjoeio]

Next step is to see if this happens locally on macOS when I develop code-server. That'll tell me if this is only for production builds.

[jsjoeio]

Since I develop code-server with code-server and Homebrew doesn't maintain versions, I'll have to download via npm and downgrade to 4.8.3

[jsjoeio]

Hmm...terminal works just fine in development 🤔

So something must be up with the build process.