Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unable to add as PWA in iPadOS nor scroll with Magic Keyboard #5861

Closed
4 tasks done
iloveicedgreentea opened this issue Dec 10, 2022 · 8 comments
Closed
4 tasks done
Labels
bug Something isn't working triage This issue needs to be triaged by a maintainer

Comments

@iloveicedgreentea
Copy link

iloveicedgreentea commented Dec 10, 2022

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

  • Web Browser: safari
  • Local OS: ipad 16.1.1, iOS 16.1
  • Remote OS: Unraid v6
  • Remote Architecture: x86-64
  • code-server --version: 1.74.0, latest as of this issue

Steps to Reproduce

  1. Open remote web UI
  2. Use Add to Home button in safari
  3. It adds a bookmark
  4. Also try to scroll with magic keyboard, nothing happens. Only finger scrolling works

Expected

It should scroll with the trackpad and it should add as a PWA

Actual

No PWA, no scrolling

Logs

No response

Screenshot/Video

No response

Does this issue happen in VS Code or GitHub Codespaces?

  • I cannot reproduce this in VS Code.
  • I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over HTTPS?

  • I am using HTTPS.

Notes

I am using nginx to proxy connection with a valid cert. Tried https and add to home still only uses a bookmark.

Note: I CANNOT scroll in github codespaces UNLESS I add it as a PWA. So the primary issue is I can’t get this to add as a PWA even with HTTPS.

nginx proxy manager -> https with letsencrypt cert -> proxy pass to port 3000 -> valid https connection

I am going to try a few more troubleshooting steps. I really love what you guys have created so I hope I can get it working

Edit: tried again with barebones nginx container and tls config, same issue. I don’t know if this is related to HTTPS because something like VueTorrent installs a PWA with just a normal HTTP connection.

@iloveicedgreentea iloveicedgreentea added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Dec 10, 2022
@iloveicedgreentea
Copy link
Author

I think the bug is with the manifest. Note here https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Add_to_home_screen#manifest

I checked my manifest in chrome on mac and its missing background_color and window.

@iloveicedgreentea
Copy link
Author

Yep, I manually edited in the background_color and window fields in my container (purple and fullscreen to test) and it was able to install as expected.

@iloveicedgreentea
Copy link
Author

So I was able to update the manifest manually and get it to install, but I still can’t scroll on anything except markdown preview windows. That I can scroll for some reason. Any other modal, no. And again I was able to scroll as expected with the Codespaces PWA on all modals.

@iloveicedgreentea
Copy link
Author

Hey, so I realized I was actually using https://hub.docker.com/r/linuxserver/code-server who said to file this upstream, which would be here… except when I sanity tested using your image directly, everything worked even without https!

So I am going to close this and file another issue with them, as its clearly something they did. Thanks!

@iloveicedgreentea
Copy link
Author

iloveicedgreentea commented Dec 10, 2022

Hmm okay so I tested again and I lost the ability to scroll. I tried to redo the steps I did before, and I can’t get it to work. At a loss here. It is running as a PWA though, but no scrolling, only on the markdown preview modal.

edit: I left the PWA running and when I loaded up, it had that loading interstitial while it reconnected, and then I was able to scroll on my last open file (some go code) until I switched files, then I lost the ability to scroll again. Hope that helps at all

I also notice right click is not intercepted and will trigger the native OS menu over the VS Code one.

I seem to consistently be able to scroll in the “output” section but not terminal or others.

@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 12, 2022

Can you test on vscode.dev and see if it has the same issue? If so, it may be upstream. Possibly related: microsoft/vscode#164220

@iloveicedgreentea
Copy link
Author

Yes it does. Added as a PWA and it behaves the same. Damn, I guess its an upstream issue :(

Hopefully they can fix it! Thanks for your help

@iloveicedgreentea
Copy link
Author

iloveicedgreentea commented Dec 12, 2022

Workaround for anyone coming across this

enable shortcuts in settings -> general -> keyboards. Scrolling worked immediately. Just annoying because it forces a keyboard UI element on many text inputs. Its definitely less than ideal so hopefully it can get fixed

Alternative workaround: use stage manager. You may have to on/off/on for it to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage This issue needs to be triaged by a maintainer
Projects
None yet
Development

No branches or pull requests

2 participants