Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] “Add to home” does not create a PWA #137

Closed
1 task done
iloveicedgreentea opened this issue Dec 10, 2022 · 4 comments
Closed
1 task done

[BUG] “Add to home” does not create a PWA #137

iloveicedgreentea opened this issue Dec 10, 2022 · 4 comments

Comments

@iloveicedgreentea
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

In ipados/ios, the add to home button should create a PWA for vscode-server. This is essential because there is either a vscode or webkit bug that breaks scrolling with the magic keyboard trackpad in safari. It works in the PWA but the add to home button only adds a bookmark. I believe this has something to do with a manifest somewhere but I am far from an expert in this domain

Expected Behavior

“Add to home” should add a PWA to the home screen

Steps To Reproduce

Launch container
Navigate to web app in safari on ios or ipad
Click add to home

Environment

- OS: Unraid v6
- How docker service was installed: Unraid via app store, using official image from your repo

CPU architecture

x86-64

Docker creation

N/A

Container logs

N/A
@github-actions
Copy link

Thanks for opening your first issue here! Be sure to follow the bug or feature issue templates!

@aptalca
Copy link
Member

aptalca commented Dec 10, 2022

That needs to be reported to the app devs

@aptalca aptalca closed this as completed Dec 10, 2022
@iloveicedgreentea
Copy link
Author

Hi, please see this issue

coder/code-server#5861

There is something wrong with your image specifically, not theirs. I tested the coder image directly and it did not have the issues I mentioned. There is both an issue with your manifest.json but also something else that prevents scroll from working.

@aptalca
Copy link
Member

aptalca commented Dec 10, 2022

Our image does not touch anything related to the manifest or the serving of the files. It just runs the upstream code server package on Ubuntu.

You didn't even fill out the issue template so we can't really help you.

One thing you can try is to clear the browser cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants