Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Update Code to 1.85 #6572

Closed
benz0li opened this issue Dec 8, 2023 · 10 comments · Fixed by #6573
Closed

[Feat]: Update Code to 1.85 #6572

benz0li opened this issue Dec 8, 2023 · 10 comments · Fixed by #6573
Labels
enhancement Some improvement that isn't a feature

Comments

@benz0li
Copy link
Contributor

benz0li commented Dec 8, 2023

What is your suggestion?

Update Code to 1.85

Why do you want this feature?

Are there any workarounds to get this functionality today?

Are you interested in submitting a PR for this?

@benz0li benz0li added the enhancement Some improvement that isn't a feature label Dec 8, 2023
@benz0li
Copy link
Contributor Author

benz0li commented Dec 8, 2023

@code-asher VS Code 1.85.0 was released yesterday: https://code.visualstudio.com/updates/v1_85

I am trying to create a pull request now.

@xabru
Copy link

xabru commented Dec 10, 2023

I would like to try the new floating windows option and how it works in the browser.

@cleardusk
Copy link

I would like to try the new floating windows option and how it works in the browser.

The same question🤔. Will code-server support the feaute float window like VSCode 1.85?

@benz0li
Copy link
Contributor Author

benz0li commented Dec 10, 2023

I would like to try the new floating windows option and how it works in the browser.

The same question🤔. Will code-server support the feaute float window like VSCode 1.85?

Yes, it does. In general, code-server supports the same features as Codespaces.
ℹ️ I.e. if it works there, it works with code-server.

@xabru @cleardusk You can also test at https://coder.jupyter.b-data.ch (Image R (base:test-devtools-docker)) where code-server-4.20.0-rc.1-linux-amd64.tar.gz with Code 1.85.0 is deployed.
👉 I have whitelisted your GitHub accounts.

@xabru
Copy link

xabru commented Dec 11, 2023

I would like to try the new floating windows option and how it works in the browser.

The same question🤔. Will code-server support the feaute float window like VSCode 1.85?

Yes, it does. In general, code-server supports the same features as Codespaces. ℹ️ I.e. if it works there, it works with code-server.

@xabru @cleardusk You can also test at https://coder.jupyter.b-data.ch (Image R (base:test-devtools-docker)) where code-server-4.20.0-rc.1-linux-amd64.tar.gz with Code 1.85.0 is deployed. 👉 I have whitelisted your GitHub accounts.

Where can I obtain the code-server-4.20.0-rc.1-linux-amd64.tar.gz file externally for testing on my host? Given the typical two-week delay in releasing new versions, I assume it will be a while before the official release is available, prompting my interest in trying it out externally.

@benz0li
Copy link
Contributor Author

benz0li commented Dec 12, 2023

Where can I obtain the code-server-4.20.0-rc.1-linux-amd64.tar.gz file externally for testing on my host?

@xabru These are personal and not official builds.

.tar.gz: https://dl.b-data.ch/coder/code-server-4.20.0-rc.1-linux-amd64.tar.gz
.deb: https://dl.b-data.ch/coder/code-server_4.20.0-rc.1_amd64.deb

@benz0li
Copy link
Contributor Author

benz0li commented Dec 12, 2023

@xabru Please be aware that the first releases are release candidates. This project follows +/- the following procedure:

Take a .1/.2-release as base for a new code-server release.
ℹ️ .0-releases have had some fundamental bugs [in the past].

  1. use the .0/.1-releases as base for a release candidate (RC)
  2. test, debug and fix; maybe do another RC-release
  3. update codebase to the .2-release
  4. test, debug and fix
  5. release

#6316 (comment)

(I stopped posting this some time ago but may start again for clarification.)

@benz0li
Copy link
Contributor Author

benz0li commented Dec 12, 2023

@xabru See #3061 (comment) on how to build yourself.

@xabru
Copy link

xabru commented Dec 12, 2023

@xabru See #3061 (comment) on how to build yourself.

Quick question: have you ever run into issues with codeserver's floating window and the Dark Reader extension? Even with Dark Reader turned off for the current domain, it's still messing with the floating window and affecting other versions like codespaces or gitpod. Seems tied to the about:blank URL in the floating window. I've been resorting to turning off Dark Reader completely. Any thoughts?

@code-asher
Copy link
Member

code-asher commented Dec 12, 2023

I am a bit swamped but am hoping to review this week, just FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants