Skip to content

Conversation

benz0li
Copy link
Contributor

@benz0li benz0li commented Dec 8, 2023

Fixes #6572

@benz0li benz0li requested a review from a team as a code owner December 8, 2023 10:37
@benz0li
Copy link
Contributor Author

benz0li commented Dec 8, 2023

@code-asher

patches/webview.diff
👉 SHA changed

patches/safari.diff, file lib/vscode/src/vs/base/common/tfIdf.ts
❓ Regex fixed?

Please review carefully thoroughly. There are some other changes/updates:

@benz0li
Copy link
Contributor Author

benz0li commented Dec 8, 2023

code-server-4.20.0-rc.1-linux-amd64.tar.gz with Code 1.85.0 is deployed at https://coder.jupyter.b-data.ch
Image R (base:test-devtools-docker).

Functionality [modified by patches] tested and found to work:

  • base-path
  • cli-window-open
  • local-storage
  • marketplace
  • proxy-url
  • service-worker
  • web view

Workspaces and Jupyter Notebooks also work fine:

  • ms-toolsai.jupyter@2023.9.100
  • ms-python.python@2023.20.0

Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me!

@code-asher code-asher merged commit 45694d3 into coder:main Dec 15, 2023
yiliang114 pushed a commit to yiliang114/code-server that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat]: Update Code to 1.85

2 participants