Skip to content

Ship with node 12 #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2020
Merged

Ship with node 12 #1998

merged 1 commit into from
Aug 26, 2020

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Aug 25, 2020 •
edited
Loading

See #1894
See #1892
See #1810

See #1904

@nhooyr
Ship with node 12
dc0bb4f 
Closes #1894
Closes #1892
Closes #1810
@nhooyr nhooyr requested a review from code-asher as a code owner August 25, 2020 19:05
@nhooyr
Copy link
Contributor Author

nhooyr commented Aug 26, 2020

Merging this in as I'm going to use it in #2001 to make sure all release builds use the official node binary and never the system binary. releases are broken for me rn with debian sid.

@nhooyr nhooyr merged commit a730bec into master Aug 26, 2020
@nhooyr nhooyr deleted the node12 branch August 26, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher Awaiting requested review from code-asher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@nhooyr