Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install.sh: Allow customizing remote shell for remote installation #2220

Merged
merged 3 commits into from
Oct 23, 2020
Merged

install.sh: Allow customizing remote shell for remote installation #2220

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
759a78d
install.sh: Rename SSH_FLAGS to RSH_FLAGS
nhooyr Oct 21, 2020
30f3030
install.sh: Allow customizing remote shell with --rsh
nhooyr Oct 21, 2020
a0b7bf2
install.sh: Default $RSH to ssh
nhooyr Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ ${not_curl_usage-}
Usage:

$arg0 [--dry-run] [--version X.X.X] [--method detect] \
[--prefix ~/.local] [user@host]
[--prefix ~/.local] [--rsh ssh] [user@host]

--dry-run
Echo the commands for the install process without running them.
Expand All @@ -45,6 +45,9 @@ Usage:
and the binary symlinked into ~/.local/bin/code-server
To install system wide pass ---prefix=/usr/local

--rsh <bin>
Specifies the remote shell for remote installation. Defaults to ssh.

- For Debian, Ubuntu and Raspbian it will install the latest deb package.
- For Fedora, CentOS, RHEL and openSUSE it will install the latest rpm package.
- For Arch Linux it will install the AUR package.
Expand Down Expand Up @@ -109,7 +112,8 @@ main() {
VERSION \
OPTIONAL \
ALL_FLAGS \
SSH_ARGS
RSH_ARGS \
RSH
nhooyr marked this conversation as resolved.
Show resolved Hide resolved

ALL_FLAGS=""
while [ "$#" -gt 0 ]; do
Expand Down Expand Up @@ -144,6 +148,13 @@ main() {
--version=*)
VERSION="$(parse_arg "$@")"
;;
--rsh)
RSH="$(parse_arg "$@")"
shift
;;
--rsh=*)
RSH="$(parse_arg "$@")"
;;
-h | --h | -help | --help)
usage
exit 0
Expand All @@ -152,7 +163,7 @@ main() {
shift
# We remove the -- added above.
ALL_FLAGS="${ALL_FLAGS% --}"
SSH_ARGS="$*"
RSH_ARGS="$*"
break
;;
-*)
Expand All @@ -161,17 +172,18 @@ main() {
exit 1
;;
*)
SSH_ARGS="$*"
RSH_ARGS="$*"
break
;;
esac

shift
done

if [ "${SSH_ARGS-}" ]; then
echoh "Installing remotely with ssh $SSH_ARGS"
curl -fsSL https://code-server.dev/install.sh | prefix "$SSH_ARGS" ssh "$SSH_ARGS" sh -s -- "$ALL_FLAGS"
if [ "${RSH_ARGS-}" ]; then
RSH="${RSH-ssh}"
echoh "Installing remotely with $RSH $RSH_ARGS"
curl -fsSL https://code-server.dev/install.sh | prefix "$RSH_ARGS" "$RSH" "$RSH_ARGS" sh -s -- "$ALL_FLAGS"
return
fi

Expand Down