Skip to content

Replace gallery with Open-VSX #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Replace gallery with Open-VSX #2659

wants to merge 2 commits into from

Conversation

oxy
Copy link

@oxy oxy commented Feb 2, 2021

After discussing internally, we've decided to just switch our default extension gallery to Open-VSX, and then document how to switch back to our old gallery. This PR just changes the default, and documentation changes are still required before we can make a release!

The hack I attempted previously broke pagination, and there is no obvious, non-invasive fix in sight due to how VSCode was designed.

Note that switching back should essentially be setting GALLERY_URL="https://extensions.coder.com/api" ITEM_URL= (intentionally blank).

Closes #1473.

TODOS

  • test with Vim

@oxy oxy requested a review from jsjoeio February 2, 2021 19:00
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@jsjoeio jsjoeio modified the milestones: v3.8.1, v3.8.2 Feb 5, 2021
@code-asher
Copy link
Member

code-asher commented Feb 5, 2021

One thing I haven't gotten around to testing yet is if the vscodevim extension from openvsx works with 1.52.1 and the web extension changes that were made there.

@jsjoeio
Copy link
Contributor

jsjoeio commented Feb 8, 2021

@oxy anything else you need from us to help move this forward?

@oxy
Copy link
Author

oxy commented Feb 8, 2021

Not really! I'm working on a second pass on the docs (should be done in the hour) and then we should be ready to merge!

@jsjoeio
Copy link
Contributor

jsjoeio commented Feb 12, 2021

Since this is still in progress and I don't want us to accidentally merge, going to move to draft

@jsjoeio jsjoeio marked this pull request as draft February 12, 2021 17:30
@oxy
Copy link
Author

oxy commented Feb 12, 2021

I did actually finish the docs and merge them into this PR - just forgot to merge this one >~<

@oxy oxy marked this pull request as ready for review February 12, 2021 19:46
@jsjoeio jsjoeio modified the milestones: v3.8.2, v3.8.3 Feb 12, 2021
@jsjoeio jsjoeio marked this pull request as draft February 12, 2021 20:45
@jsjoeio
Copy link
Contributor

jsjoeio commented Feb 12, 2021

Moving back to draft - we need to test this with Vim

@pojntfx
Copy link

pojntfx commented Feb 14, 2021

Just tested the latest version from OpenVSX, seems to work fine:

Vim-OpenVSX.mp4

@code-asher
Copy link
Member

code-asher commented Feb 16, 2021

Ah yup if you install it manually it should work but installing from the UI seems to break because it attempts to load it as a web extension which OpenVSX doesn't seem to support yet.

@jsjoeio
Copy link
Contributor

jsjoeio commented Feb 18, 2021

Regardless, thanks for testing it out and posting a video @pojntfx 🎉 Hopefully we can get this sorted soon!

@jsjoeio jsjoeio modified the milestones: v3.9.1, v3.9.2 Feb 24, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Mar 2, 2021

Closing for now because we need a few things in place before we can fully implement and merge this PR

@jsjoeio jsjoeio closed this Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants