feat: proxy URI environment variable #4681

code-asher · 2022-01-04T20:00:59Z

Plus tests. Closes #1510.

This will let us test extension-related features (like the proxy URI). I removed the environment variables in the script because they override the ones you set yourself. We still set defaults in constants.ts.

This adds the VSCODE_PROXY_URI environment variable.

jsjoeio

This is an awesome! Seems like it'll be easier to test extensions with this 👏

codecov · 2022-01-04T20:45:05Z

Codecov Report

Merging #4681 (19536d4) into main (f04fcf2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4681   +/-   ##
=======================================
  Coverage   69.10%   69.10%           
=======================================
  Files          29       29           
  Lines        1638     1638           
  Branches      341      341           
=======================================
  Hits         1132     1132           
  Misses        430      430           
  Partials       76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f04fcf2...19536d4. Read the comment docs.

code-asher added 4 commits January 4, 2022 19:57

Add test extension

3fa30c8

This will let us test extension-related features (like the proxy URI). I removed the environment variables in the script because they override the ones you set yourself. We still set defaults in constants.ts.

Add changelog entry for VSCODE_PROXY_URI

0d2c9b5

Add terminal test for VSCODE_PROXY_URI

cdc1f51

Update VS Code

2dd183c

This adds the VSCODE_PROXY_URI environment variable.

code-asher requested a review from a team January 4, 2022 20:01

code-asher changed the title ~~Add proxy URI environment variable~~ feat: proxy URI environment variable Jan 4, 2022

jsjoeio approved these changes Jan 4, 2022

View reviewed changes

code-asher added 3 commits January 4, 2022 20:03

fixup! Add changelog entry for VSCODE_PROXY_URI

0d7cc81

fixup! Update VS Code

4e8eafd

fixup! fixup! Add changelog entry for VSCODE_PROXY_URI

19536d4

code-asher merged commit 3d99998 into coder:main Jan 4, 2022

code-asher deleted the http-referer branch January 4, 2022 21:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: proxy URI environment variable #4681

feat: proxy URI environment variable #4681

code-asher commented Jan 4, 2022 •

edited

Loading

jsjoeio left a comment

codecov bot commented Jan 4, 2022

feat: proxy URI environment variable #4681

feat: proxy URI environment variable #4681

Conversation

code-asher commented Jan 4, 2022 • edited Loading

jsjoeio left a comment

Choose a reason for hiding this comment

codecov bot commented Jan 4, 2022

Codecov Report

code-asher commented Jan 4, 2022 •

edited

Loading