Update Code to 1.75.0 #6004

code-asher · 2023-02-06T22:12:56Z

getting-started.diff: The way to get an icon's class changed
proxy-uri.diff: The product service is passed in so we can get the proxy URI from that now instead of passing it in separately.

Closes #5995
Closes #5988

- getting-started.diff: The way to get an icon's class changed - proxy-uri.diff: The product service is passed in so we can get the proxy URI from that now instead of passing it in separately.

Something in how/when Code displays the trust dialog appears to have changed, failing the test. I am not sure it makes sense for us to be testing upstream code anyway.

Since we spawn the watch script with ts-node it was using ts-node for the web server spawn as well. With latest Code there are for some reason type errors (it cannot find @types/node) but this is already compiled code which already passed type checks; any type errors here are useless. To fix spawn with regular Node.

codecov · 2023-02-07T20:11:03Z

Codecov Report

Merging #6004 (8b5e2c3) into main (e5a2537) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6004   +/-   ##
=======================================
  Coverage   71.75%   71.75%           
=======================================
  Files          31       31           
  Lines        1696     1696           
  Branches      372      372           
=======================================
  Hits         1217     1217           
  Misses        401      401           
  Partials       78       78

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5a2537...8b5e2c3. Read the comment docs.

benz0li · 2023-02-09T16:17:45Z

code-server-4.10.0-rc.0-linux-amd64.tar.gz from Release v4.10.0-rc.0 is deployed at https://coder.jupyter.b-data.ch; Image R (base:test-devtools).

Functionality [modified by patches] tested and found to work:

base-path
cli-window-open
local-storage
marketplace
proxy-url
service-worker
webview

Jupyter Notebooks also work fine:

ms-toolsai.jupyter@2022.10.110
ms-python.python@2023.2.0

Terminal is not rendered properly ("terminal.integrated.gpuAcceleration": "auto") in Safari:

Workaround: "terminal.integrated.gpuAcceleration": "off"

Most probably related to:

Terminal rendering issues in Codespaces (iPadOS) microsoft/vscode#163448
- Disable ImageBitmap optimization when on Safari xtermjs/xterm.js#4218

code-asher · 2023-02-09T20:49:38Z

@benz0li thank you!! I will make a regular release tomorrow assuming no issues pop up.

benz0li · 2023-02-10T07:45:59Z

It is worth updating Code to 1.75.1 first.

Maybe the problem with Terminal rendering in Safari is resolved in this release.
👉 It does not mention it, but you never know...

I am happy to test again.

benz0li · 2023-02-10T07:55:26Z

@code-asher Consider taking a .2-release as base for a new code-server release.
ℹ️ .0-releases have had some fundamental bugs.

i.e.

use the .1-release as base for a release candidate (RC)
test, debug and fix; maybe do another RC-release
update codebase to the .2-release
test, debug and fix
release

code-asher · 2023-02-10T18:37:48Z

@benz0li That makes sense to me. I will get us updated to 1.75.1 today.

Starting with .1 sounds good to me if it makes things easier. I will do that going forward.

bala · 2023-02-12T14:07:37Z

code-server-4.10.0-rc.0-linux-amd64.tar.gz from Release v4.10.0-rc.0 is deployed at https://coder.jupyter.b-data.ch; Image R (base:test-devtools).

Functionality [modified by patches] tested and found to work:

base-path

cli-window-open

local-storage

marketplace

proxy-url

service-worker

webview

Jupyter Notebooks also work fine:

ms-toolsai.jupyter@2022.10.110

ms-python.python@2023.2.0

Terminal is not rendered properly ("terminal.integrated.gpuAcceleration": "auto") in Safari:

Workaround: "terminal.integrated.gpuAcceleration": "off"

Most probably related to:

Terminal rendering issues in Codespaces (iPadOS) microsoft/vscode#163448

Disable ImageBitmap optimization when on Safari xtermjs/xterm.js#4218

@benz0li does this work stable? Can I update my primary Instance with this release ? @code-asher when can we expect the 4.10 with vscode updated to 1.75.1?

benz0li · 2023-02-12T14:35:19Z

@bala I do not recommend deploying a release candidate to a production server.
ℹ️ Your GitHub user should still be whitelisted at https://coder.jupyter.b-data.ch/. You may log in and test yourself.

code-asher · 2023-02-13T16:33:06Z

Sorry did not have time to update last Friday, hope to get to it today.

code-asher · 2023-02-13T18:18:19Z

Published the next release candidate with 1.75.1! Honestly have not even ran them yet, just updated Code and hit the release workflow. Will test more later.

benz0li · 2023-02-13T18:59:28Z

code-server-4.10.0-rc.1-linux-amd64.tar.gz from Release v4.10.0-rc.1 is deployed at https://coder.jupyter.b-data.ch; Image R (base:test-devtools).

Functionality [modified by patches] tested and found to work:

base-path
cli-window-open
local-storage
marketplace
proxy-url
service-worker
webview

Jupyter Notebooks also work fine:

ms-toolsai.jupyter@2022.10.110
ms-python.python@2023.2.0

Terminal is still not rendered properly ("terminal.integrated.gpuAcceleration": "auto") in Safari

Maybe @Tyriar knows more about why something like this is happening (again) with Safari.
ℹ️ My client: macOS version 13.2 (Ventura), Safari version 16.3 (18614.4.6.1.5)

@Tyriar: I have whitelisted your GitHub user at https://coder.jupyter.b-data.ch/ so you may have a look at it yourself.

Tyriar · 2023-02-13T21:01:09Z

We disable the webgl renderer on Safari still when it's auto. Break here to see what's happening:

https://github.com/microsoft/vscode/blob/c9753ca41c29f4d7aff568aa9159ee021b3c9307/src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts#L364-L366

benz0li · 2023-02-14T06:45:16Z

We disable the webgl renderer on Safari still when it's auto.

I am aware of that. (I have been in the loop at xtermjs/xterm.js#3357 (comment))

This was announced with Code v1.75:

January 2023 (version 1.75)

[...]

Terminal

[...]

Powerline triangle and diagonal line custom glyphs

GPU-accelerated terminals now get pixel-perfect custom glyphs for the triangle and diagonal line Powerline extra symbols glyphs (U+E0B8-U+E0BF). These characters are ambiguous as to whether they are single or double width characters and differ depending on the font used, so we chose to render them as single width.

Before:

Triangles and diagonal line previously could display with bad anti-aliasing and odd borders

After:

In my case: Before (Code version: 1.73.1):

In my case: After (Code version: 1.75.1):

ℹ️ Font: MesloLGS NF (HiDPI display)

Cross references:

Interesting to read: Powerlevel10k > Troubleshooting > Sub-pixel imperfections around powerline symbols

("terminal.integrated.customGlyphs": false seems to have no effect while "terminal.integrated.gpuAcceleration": "auto".)

benz0li · 2023-02-14T07:03:50Z

Workaround on latest systems (Safari 16 and above): Enable Develop menu; Develop > User Agent: Choose either Microsoft Edge, Google Chrome or Firefox.

Tyriar · 2023-02-14T15:29:32Z

In my case: After (Code version: 1.75.1):

That's tracked in xtermjs/xterm.js#4120

code-asher requested a review from a team as a code owner February 6, 2023 22:12

code-asher force-pushed the vscode-1.75.0 branch from 8a30db8 to b96fb1e Compare February 7, 2023 16:51

code-asher added 3 commits February 7, 2023 11:07

Update Code to 1.75.0

872ef90

- getting-started.diff: The way to get an icon's class changed - proxy-uri.diff: The product service is passed in so we can get the proxy URI from that now instead of passing it in separately.

Remove workspace trust test

aa56f97

Something in how/when Code displays the trust dialog appears to have changed, failing the test. I am not sure it makes sense for us to be testing upstream code anyway.

code-asher force-pushed the vscode-1.75.0 branch from b96fb1e to 6329796 Compare February 7, 2023 20:07

Fix some workers not loading

8b5e2c3

code-asher force-pushed the vscode-1.75.0 branch from 3fe5312 to 8b5e2c3 Compare February 7, 2023 21:41

code-asher merged commit 71ff747 into coder:main Feb 7, 2023

code-asher deleted the vscode-1.75.0 branch February 7, 2023 22:22

benz0li mentioned this pull request Feb 14, 2023

Remove deprecated --link #6018

Merged

benz0li mentioned this pull request Feb 22, 2023

[Bug]: The terminal cannot display normally with "terminal.integrated.gpuAcceleration": "on" (the default setting) #6027

Closed

4 tasks

benz0li mentioned this pull request Mar 10, 2023

[Feat]: Upgrade Vscode to 1.76 #6050

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Code to 1.75.0 #6004

Update Code to 1.75.0 #6004

code-asher commented Feb 6, 2023

codecov bot commented Feb 7, 2023 •

edited

Loading

benz0li commented Feb 9, 2023

code-asher commented Feb 9, 2023

benz0li commented Feb 10, 2023

benz0li commented Feb 10, 2023

code-asher commented Feb 10, 2023

bala commented Feb 12, 2023

benz0li commented Feb 12, 2023 •

edited

Loading

code-asher commented Feb 13, 2023

code-asher commented Feb 13, 2023 •

edited

Loading

benz0li commented Feb 13, 2023

Tyriar commented Feb 13, 2023

benz0li commented Feb 14, 2023 •

edited

Loading

January 2023 (version 1.75)

Terminal

Powerline triangle and diagonal line custom glyphs

benz0li commented Feb 14, 2023

Tyriar commented Feb 14, 2023

Update Code to 1.75.0 #6004

Update Code to 1.75.0 #6004

Conversation

code-asher commented Feb 6, 2023

codecov bot commented Feb 7, 2023 • edited Loading

Codecov Report

benz0li commented Feb 9, 2023

code-asher commented Feb 9, 2023

benz0li commented Feb 10, 2023

benz0li commented Feb 10, 2023

code-asher commented Feb 10, 2023

bala commented Feb 12, 2023

benz0li commented Feb 12, 2023 • edited Loading

code-asher commented Feb 13, 2023

code-asher commented Feb 13, 2023 • edited Loading

benz0li commented Feb 13, 2023

Tyriar commented Feb 13, 2023

benz0li commented Feb 14, 2023 • edited Loading

January 2023 (version 1.75)

Terminal

Powerline triangle and diagonal line custom glyphs

benz0li commented Feb 14, 2023

Tyriar commented Feb 14, 2023

codecov bot commented Feb 7, 2023 •

edited

Loading

benz0li commented Feb 12, 2023 •

edited

Loading

code-asher commented Feb 13, 2023 •

edited

Loading

benz0li commented Feb 14, 2023 •

edited

Loading