-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --disable-proxy option #6349
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6349 +/- ##
==========================================
+ Coverage 73.67% 73.68% +0.01%
==========================================
Files 31 31
Lines 1869 1885 +16
Branches 401 406 +5
==========================================
+ Hits 1377 1389 +12
- Misses 415 419 +4
Partials 77 77
Continue to review full report in Codecov by Sentry.
|
980b005
to
c9cca31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Implementation and tests look flawless.
Generally, these two features would be used together, but I didn't want to tightly couple them.
Good call, there are cases where they are used separately so this is perfect.
@code-asher Thanks for the quick merge! Any idea when this change will be released? |
We generally have a monthly release cadence, usually as soon as we merge the latest Code release from upstream. This PR just barely missed the previous release so if we wait it would be released next month (sans a patch release upstream) but I am not opposed to doing another release in the meantime if it seems urgent. |
@code-asher It's not super urgent, but since this is related to security/authentication, it's something we'd like to be able to deploy soon. If it's not too much trouble, doing another release would be appreciated. |
No problem, seems reasonable to me. Our usual pattern is to put out an RC and then promote the release the next day if nothing goes wrong so I will go ahead and do that now. |
@code-asher awesome, thank you! |
Fixes # #6348
This change adds a
disable-proxy
option (set by--disable-proxy
flag,CS_DISABLE_PROXY=1
orCS_DISABLE_PROXY=true
, ordisable-proxy
config), which disables the proxy routes to forwarded ports, includingthe domain and path proxy routes over HTTP and WebSockets.
Note, it does not patch VS Code itself to block the auto port forwarding, but that can be disabled with
remote.autoForwardPorts=false
. Generally, these two features would be used together, but I didn't want to tightly couple them.