Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm boolean fix #6563

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Helm boolean fix #6563

merged 1 commit into from
Dec 4, 2023

Conversation

rushyrush
Copy link
Contributor

Helm error:

  • cannot unmarshal bool into Go struct field EnvVar.spec.template.spec.containers.env.value of type string

Must wrap any true or false into quotes when passing values to env object.

code-asher
code-asher approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@code-asher code-asher enabled auto-merge (squash) December 4, 2023 19:13
@code-asher code-asher merged commit 1fac50d into coder:main Dec 4, 2023
yiliang114 pushed a commit to yiliang114/code-server that referenced this pull request Jan 23, 2025
@rushyrush @yiliang114
Fix Helm boolean environment variable (coder#6563)
f255c5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rushyrush @code-asher