-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Code to 1.93.0 #6984
Update Code to 1.93.0 #6984
Conversation
Ping @code-asher: Functionality [modified by patches] tested and found to work:
Workspaces and Jupyter Notebooks also work fine:
@renkun-ken: R Extension: The first |
Ping @randy3k: R Extension: The first |
FYI @renkun-ken @randy3k: The browser console states
ℹ️ This does not happen with previous versions of |
@code-asher Please check the failing Firefox upload/download end-to-end tests. Thank you. |
@code-asher Code 1.93.1 is out. Unfortunately, I do not have the time to update this PR. You are on your own. |
I will try to get to it today, but it might be next week... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6984 +/- ##
=======================================
Coverage ? 72.63%
=======================================
Files ? 31
Lines ? 1904
Branches ? 412
=======================================
Hits ? 1383
Misses ? 441
Partials ? 80 Continue to review full report in Codecov by Sentry.
|
a15d241
to
aa04434
Compare
aa04434
to
1676fd9
Compare
1a60279
to
dea5e8d
Compare
@code-asher Thanks for all your efforts. |
9c4d5a6
to
f005242
Compare
f005242
to
a95331d
Compare
Still not sure what is going on with context menus in Firefox, but I verified the tests manually so for now I am going to disable them and experiment later. Will merge now and get a release out soon-ish. |
Also @benz0li thanks for getting the update started! |
Fixes #6955